Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pytest.mark.net on net-enabled test #391

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

pndurette
Copy link
Owner

@pndurette pndurette commented Jan 13, 2023

This PR,

  • Adds a missing @pytest.mark.net for a test that required a network connection

Fixes #344

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9b54fc1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 4180aa3 differs from pull request most recent head d7d5b1c. Consider uploading reports for the commit d7d5b1c to get more accurate results

@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage        ?   98.17%           
=======================================
  Files           ?       13           
  Lines           ?      329           
  Branches        ?        0           
=======================================
  Hits            ?      323           
  Misses          ?        6           
  Partials        ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pndurette pndurette marked this pull request as ready for review January 13, 2023 07:30
@pndurette pndurette merged commit 3667f06 into main Jan 13, 2023
@pndurette pndurette deleted the missing_not_net_test branch January 13, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One more test needs to be marked as .net
1 participant