Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

external sharing is disabled globally #12

Open
ecomDev33 opened this issue Jul 30, 2020 · 7 comments
Open

external sharing is disabled globally #12

ecomDev33 opened this issue Jul 30, 2020 · 7 comments

Comments

@ecomDev33
Copy link

I ran the command pwd as requested
Apply-PnPTenantTemplate -Path .\SiteDesignsStudio.pnp -Parameter @{TenantName=$tenantName; SitePath=$sitePath; TenantId=$tenantId}

The collection site is well created but external sharing has also been disabled globally on the Tenant.
I reproduced the same issue on another Tenant.

Why the process disable external sharing?

@ypcode
Copy link
Collaborator

ypcode commented Jul 30, 2020

Hello @ecomDev33,

That is indeed an issue! It definitely should not!
I'll try to fix that ASAP.

It is probably related to the fact that the Tenant template that is applied is changing this setting. Let me double check :)

Best regards,
Yannick

@ypcode ypcode self-assigned this Jul 30, 2020
@ypcode
Copy link
Collaborator

ypcode commented Jul 30, 2020

Hey,

I just checked and there is nothing in the template that explicitly affects that tenant wide external sharing setting.
Could you please provide more information about what settings you see being affected by the setup script ?

Best regards,
Yannick

@ghost
Copy link

ghost commented Aug 5, 2020

Hi @ypcode
I also reproduce this issue. Bellow compliance and security logs
First event : Update application failure during deployment
[ { "Name": "resultType", "Value": "Failure" }, { "Name": "resultDescription", "Value": "Microsoft.Online.DirectoryServices.InvalidDirectoryValueException" }, { "Name": "auditEventCategory", "Value": "ApplicationManagement" }, { "Name": "nCloud", "Value": "<null>" }, { "Name": "actorContextId", "Value": "" }, { "Name": "actorObjectId", "Value": "" }, { "Name": "actorObjectClass", "Value": "User" }, { "Name": "actorUPN", "Value": "CustomAddr@contoso.com" }, { "Name": "actorPUID", "Value": "10032000BD00505E" }, { "Name": "teamName", "Value": "MSODS." }, { "Name": "targetContextId", "Value": "" }, { "Name": "targetObjectId", "Value": "" }, { "Name": "extendedAuditEventCategory", "Value": "Application" }, { "Name": "targetName", "Value": "SharePoint Online Client Extensibility Web Application Principal" }, { "Name": "targetIncludedUpdatedProperties", "Value": "[\"AppAddress\",\"MethodExecutionResult.\"]" }, { "Name": "correlationId", "Value": "b70cce11-1590-4403-a14f-31221c32b8f7" }, { "Name": "version", "Value": "2" }, { "Name": "additionalDetails", "Value": "{\"User-Agent\":\"Microsoft Azure Graph Client Library 1.0\"}" }, { "Name": "env_ver", "Value": "2.1" }, { "Name": "env_name", "Value": "#Ifx.AuditSchema#IfxMsods.AuditCommonEvent" }, { "Name": "env_time", "Value": "2020-08-05T11:22:59.2842878Z" }, { "Name": "env_epoch", "Value": "E2DG8" }, { "Name": "env_seqNum", "Value": "25249049" }, { "Name": "env_popSample", "Value": "0" }, { "Name": "env_iKey", "Value": "ikey" }, { "Name": "env_flags", "Value": "257" }, { "Name": "env_cv", "Value": "" }, { "Name": "env_os", "Value": "<null>" }, { "Name": "env_osVer", "Value": "<null>" }, { "Name": "env_appId", "Value": "restdirectoryservice" }, { "Name": "env_appVer", "Value": "1.0.12039.1" }, { "Name": "env_cloud_ver", "Value": "1.0" }, { "Name": "env_cloud_name", "Value": "MSO-AM3" }, { "Name": "env_cloud_role", "Value": "restdirectoryservice" }, { "Name": "env_cloud_roleVer", "Value": "1.0.12039.1" }, { "Name": "env_cloud_roleInstance", "Value": "" }, { "Name": "env_cloud_environment", "Value": "PROD" }, { "Name": "env_cloud_deploymentUnit", "Value": "R3" } ]

Next event, change sharing policies
Operation:SharingPolicyChanged
OrganizationId:
RecordType:4
UserAgent:NONISV|SharePointPnP|PnPPS/3.23.2007.1
UserId:
UserKey:i:
UserType:0
Version:1
Workload:SharePoint

[ { "Name": "ShareWithExistingGuestsOnly", "NewValue": "Disabled", "OldValue": "Enabled" }, { "Name": "ShareWithGuests", "NewValue": "Disabled", "OldValue": "Enabled" }, { "Name": "ShareUsingAnonymousLinks", "NewValue": "Disabled", "OldValue": "Disabled" } ]

Best regards,
Emmanuel

@ypcode
Copy link
Collaborator

ypcode commented Aug 5, 2020

Hi guys,

Thank you for reporting, I double-checked the .pnp package file and it looks indeed that there is a setting that might cause that. AllowFileSharingForGuestUsers

...
  <pnp:Sequence ID="MAIN-SEQUENCE">
    <pnp:SiteCollections>
      <pnp:SiteCollection d4p1:type="pnp:CommunicationSite" Title="Site Designs Studio" .... AllowFileSharingForGuestUsers="false" ....>
        <pnp:Templates>
          <pnp:ProvisioningTemplateReference ID="SITE-DESIGNS-STUDIO-V2-APP" />
        </pnp:Templates>
      </pnp:SiteCollection>
    </pnp:SiteCollections>
  </pnp:Sequence>
...

It is really an odd issue but it looks like the XML is somehow altered when saved in the .pnp package

However, I am not sure since it should only affect the created site collection and not the whole tenant...
I rebuilt and tweaked the PnP package making sure this property is no longer there and escalated that issue to the PnP PowerShell team.

Could you please guys give it another try with the latest setup files ?

Regards,
Yannick

@ghost
Copy link

ghost commented Aug 6, 2020

Hi @ypcode

I tried to deployed with the latest setup files but it still disable external sharing globally
Do you really need to specify sharing capacity configuration in pnp package ?
Regards,
Emmanuel

@o-utofbounds
Copy link

i just deployed the latest version and i had the issue

@ypcode
Copy link
Collaborator

ypcode commented Aug 6, 2020

Hi guys,

Thanks for confirming! I do think the issue comes from the PnP PowerShell cmdlet used in the setup script. Or at least the tenant provisioning engine since the template itself doesn't explicitly touch the sharing settings.

I'll keep you informed as soon as I get more info about it!

Thank you very much for reporting that!

Regards,
Yannick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants