Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSVC build on CI #109

Merged
merged 20 commits into from
Feb 16, 2019
Merged

Fix MSVC build on CI #109

merged 20 commits into from
Feb 16, 2019

Conversation

wx257osn2
Copy link
Contributor

@wx257osn2 wx257osn2 commented Feb 14, 2019 •
edited
Loading

Building poac using MSVC on AppVeyor CI is failed now.
This PR fixes that.

Summary of changes in this PR

  • Now building poac using MSVC on AppVeyor is succeeded
  • Fix some compile options for MSVC
  • AppVeyor has built 32bit binary for x64 platform, but now AppVeyor build 64bit binary correctly

@ken-matsui
Copy link
Member

Thank you for your cooperation.
Finally, I will squash and merge appveyor branch as multiple authors. By the way are you ok with this?
Do you have any demands?

@wx257osn2
Copy link
Contributor Author

wx257osn2 commented Feb 15, 2019 •
edited
Loading

@matken11235 When this PR will make AppVeyor CI passed, please make me the one of co-authors.

If you want to know my commiter information, please tell me... on Twitter.
(Of course, you can extract the information from my commits.)

@wx257osn2 wx257osn2 marked this pull request as ready for review February 15, 2019 07:44
@wx257osn2 wx257osn2 changed the title WIP: Fix MSVC build on CI Fix MSVC build on CI Feb 15, 2019
@ken-matsui
Copy link
Member

I appreciate your cooperation. Thanks!

@ken-matsui ken-matsui merged commit abd42d3 into cabinpkg:appveyor Feb 16, 2019
@ken-matsui ken-matsui mentioned this pull request Feb 16, 2019
Merged
@wx257osn2 wx257osn2 deleted the for-msvc branch February 16, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wx257osn2 @ken-matsui