Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) FF truncated text in input #121

Merged
merged 4 commits into from
Sep 10, 2018
Merged

(Fix) FF truncated text in input #121

merged 4 commits into from
Sep 10, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #112

Truncated text inside of inputs in FF is fixed with decreasing of top and bottom paddings.

Copy link

@dennis00010011b dennis00010011b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov
Add token- field decimals became truncated

Why we need input of decimals in section 'add token' ? Decimals defined by contract and could not be changed by user, aren't it?

screen shot 2018-09-10 at 7 18 25 am

@vbaranov
Copy link
Collaborator Author

Why we need input of decimals in section 'add token' ? Decimals defined by contract and could not be changed by user, aren't it?

@dennis00010011b you're completely right. Symbol and decimals are trying to be autofilled from contract address. In the case of successful autofill, we shouldn't allow a user to change decimals and symbol. Thus,

  • if autofill is successful, we display auto-filled values and disable symbol and decimals fields.
  • if autofill is not successful (for any reason), we keep symbol and decimals editable for manual fill.
    Would you mind of such a proposal?

@vbaranov vbaranov merged commit 95220d9 into develop Sep 10, 2018
@ghost ghost removed the awaiting for review label Sep 10, 2018
@vbaranov vbaranov deleted the ff-truncated-text branch September 10, 2018 18:00
@dennis00010011b
Copy link

@vbaranov

if autofill is successful, we display auto-filled values and disable symbol and decimals fields.
if autofill is not successful (for any reason), we keep symbol and decimals editable for manual fill.

I think it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants