(Fix) Error is constantly shown through screens #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dennis00010011b
approved these changes
Sep 11, 2018
fvictorio
reviewed
Sep 11, 2018
| @@ -502,7 +502,7 @@ function requestRevealSeed (password) { | |||
| return new Promise((resolve, reject) => { | |||
| background.submitPassword(password, err => { | |||
| if (err) { | |||
| dispatch(actions.displayWarning(err.message)) | |||
| dispatch(actions.displayWarning(err)) | |||
There was a problem hiding this comment.
What is the reason for this change? Every ohter usage of displayWarning seems to do displayWarning(err.message).
There was a problem hiding this comment.
@fvictorio this is because submitPassword actually returns string and not Error object:
https://github.com/vbaranov/KeyringController/blob/a3251d6306f155c23eba785ddf9ef75a2a609e32/index.js#L449. But it will be unified in the next version of eth-keychain-controller: all catches will return Error object.
patitonar
approved these changes
Sep 11, 2018
fvictorio
approved these changes
Sep 12, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #110
Cleaning of the warning message was added on
componentWillUnmountevent for every screen, where it can appear during screen lifecycle.