Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Clear an error on successful response from tokens balances #128

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #124

Copy link

@dennis00010011b dennis00010011b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbaranov
Disabled to add token to localhost network if token was added in other network.

Steps:

  1. Add token to Sokol
  2. Switch to localhost

Expected result: should be option to add token, button 'Add token' should be displayed

Actual result: warning displayed even if tokens were added to localhost
screen shot 2018-09-11 at 5 35 15 am

@vbaranov
Copy link
Collaborator Author

@dennis00010011b what you're asking is a feature request. Addition of tokens is not supported for private networks. Please create a separate issue for that.

@vbaranov vbaranov merged commit 25a605a into develop Sep 11, 2018
@ghost ghost removed the awaiting for review label Sep 11, 2018
@vbaranov vbaranov deleted the switch-from-localhost-tokens-display-bug branch September 11, 2018 21:29
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants