Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Search tokens in POA network #140

Merged
merged 6 commits into from
Oct 2, 2018
Merged

Conversation

vbaranov
Copy link
Collaborator

Relates to #134
Based on #135. Should be merged after #135.

Support of search tokens in POA Network:

2018-09-19 18 45 35

The database of tokens is in https://github.com/poanetwork/poa-contract-metadata/tree/master

@dennis00010011b
Copy link

@vbaranov
should be Search results

screen shot 2018-09-20 at 6 36 34 am

@vbaranov
Copy link
Collaborator Author

ah, I see. 🤔 Do we need this text there at all? It takes pretty much space. What do you think @dennis00010011b?

@dennis00010011b
Copy link

ah, I see. 🤔 Do we need this text there at all? It takes pretty much space. What do you think @dennis00010011b?

I think it's useless ,we can eliminate it

@vbaranov
Copy link
Collaborator Author

I think it's useless ,we can eliminate it

"searchResults" is removed

@dennis00010011b @fvictorio @patitonar PR is ready for review finally.

@vbaranov vbaranov added this to the 4.8.6 milestone Sep 27, 2018
@vbaranov vbaranov merged commit d4adec4 into develop Oct 2, 2018
@ghost ghost removed the awaiting for review label Oct 2, 2018
@vbaranov vbaranov deleted the search-POA-tokens branch October 2, 2018 15:33
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants