Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Transfer tokens #145

Merged
merged 21 commits into from
Oct 3, 2018
Merged

(Feature) Transfer tokens #145

merged 21 commits into from
Oct 3, 2018

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Sep 27, 2018

Relates to #134
Built on #142 (should be merged after this PR)

The last part of tokens' management support; the ability to transfer tokens.

2018-09-27 14 24 37

2018-09-27 14 25 20

2018-09-27 14 25 34

@dennis00010011b e2e tests are affected with this feature, could you please update e2e tests to support this feature also?

@dennis00010011b
Copy link

dennis00010011b commented Sep 27, 2018

@vbaranov
Send tokens dialog:

  1. No decimals validation. There is should be any error message like ' ... decimals should not exceed the amount of decimals specified... ' if fractional part of amount longer than specified of decimals

  2. Can not send valid amount of token with more than 16 significant digits (even if token decimals =18), button 'Next ' is non-clickable, uncaught error in console

screen shot 2018-09-27 at 6 23 33 am

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

No decimals validation. There is should be any error message like ' ... decimals should not exceed the amount of decimals specified... ' if fractional part of amount longer than specified of decimals

Could you please create an additional issue for that? For now, all extra decimals should be truncated on the confirmation page before sending transaction.

Can not send valid amount of token with more than 16 significant digits (even if token decimals =18), button 'Next ' is non-clickable, uncaught error in console

Should work now (bignumber errors were disabled for this page)

@dennis00010011b
Copy link

dennis00010011b commented Sep 27, 2018

@vbaranov
Send tokens: error message typo
Should be '.. token's ..'
screen shot 2018-09-27 at 9 12 41 am

I can fix it in e2e PR

@vbaranov
Copy link
Collaborator Author

I can fix it in e2e PR

@dennis00010011b thank you

@dennis00010011b
Copy link

@vbaranov
Firefox, Send tokens screen:
-field address has no arrow icon
-there is no hex addresses in dropdown list

screen shot 2018-09-28 at 4 08 59 am

@dennis00010011b
Copy link

@dennis00010011b
Copy link

@vbaranov
Firefox-Send tokens: no error message if amount too precise, clicking button 'Next' leads to open 'Confirm transaction' dialog

It works in Chrome:

screen shot 2018-09-28 at 6 09 04 am

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

Should be const parts = input.split('.') ?

Right, nice catch!

Could you create additional issues for FF bugs with the label FF related?

@vbaranov vbaranov merged commit 220b357 into develop Oct 3, 2018
@ghost ghost removed the awaiting for review label Oct 3, 2018
@vbaranov vbaranov deleted the tokens-send branch October 3, 2018 12:01
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants