Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Add custom tokens validation #149

Merged
merged 16 commits into from
Oct 16, 2018
Merged

(Fix) Add custom tokens validation #149

merged 16 commits into from
Oct 16, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #144
Relates to #131
Relates to #126 (#126 (comment))

Built on #140 (should be merged after it)

Custom token page was refactored

  • Validation on the addition is modified: a custom token that exposes not empty decimals and symbol properties can be added only.
  • Custom tokens can be added for localhost environment
  • Decimals field is prohibited to be edited

@vbaranov
Copy link
Collaborator Author

@dennis00010011b could you take a look to failed integration and e2e tests?

@vbaranov
Copy link
Collaborator Author

vbaranov commented Oct 3, 2018

@dennis00010011b could you please resolve merging conflict with e2e tests?

@dennis00010011b
Copy link

@vbaranov

Since I have no write access to this repo I've created PR #151 which should resolve merging conflict

@vbaranov vbaranov merged commit 27dd7a4 into develop Oct 16, 2018
@ghost ghost removed the awaiting for review label Oct 16, 2018
@vbaranov vbaranov deleted the add-tokens-validation branch October 16, 2018 15:32
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants