(Fix) memory leaks: unreleased interval and events #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dennis00010011b
approved these changes
Oct 30, 2018
patitonar
approved these changes
Oct 30, 2018
fvictorio
approved these changes
Oct 31, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #157
In addition to this memory leak fix ee568d5, that has been merged previously in this PR #169 into dev branch of NW, unreleased interval and
transitionstart,transitionendevents could cause memory leaks in NW, also.This PR fixes it with implementing of removal of events on unmounting of a component and clearing of
_phishingUpdateIntervalRefinterval.Also, removal of event listener on notification click has been added in this commit 3b878f3