Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) auto-detect tokens for POA #175

Merged
merged 14 commits into from
Nov 6, 2018
Merged

Conversation

vbaranov
Copy link
Collaborator

Auto-detect tokens, owned by the currently unlocked account from the list of known tokens for POA core network (as it works for Mainnet)

@ghost ghost assigned vbaranov Oct 30, 2018
@ghost ghost added the in progress label Oct 30, 2018
@vbaranov vbaranov added this to the 4.8.7 milestone Oct 30, 2018
@dennis00010011b
Copy link

@vbaranov
Auto-detection works only for network , where account was added. If account has tokens both in Mainnet and POA networks and such account has been added in POA then Mainnet's tokens won't be autodetected. And vise versa

Steps:

  1. Set provider POA
  2. Add account, that has owned some tokens in Mainnet and POA networks
  3. Observe the token's balance in POA network
  4. Switch to Mainnet
  5. Observe the token's balance in Mainnet

Expected result:

  • tokens, owned by account in Mainnet, should be shown

Actual result:

  • tokens weren't auto-detected

https://www.useloom.com/share/69969815fc32474db96c7d60b9ee1f9a

@vbaranov
Copy link
Collaborator Author

@vbaranov
Auto-detection works only for network , where account was added. If account has tokens both in Mainnet and POA networks and such account has been added in POA then Mainnet's tokens won't be autodetected. And vise versa

Steps:

  1. Set provider POA
  2. Add account, that has owned some tokens in Mainnet and POA networks
  3. Observe the token's balance in POA network
  4. Switch to Mainnet
  5. Observe the token's balance in Mainnet

Expected result:

  • tokens, owned by account in Mainnet, should be shown

Actual result:

  • tokens weren't auto-detected

https://www.useloom.com/share/69969815fc32474db96c7d60b9ee1f9a

@dennis00010011b basically, tokens auto-detection function executes every 3 minutes. Thereby, your tokens after switching to another chain should appear within 3 minutes. Nevertheless, I have added tokens auto-detection on chain change here b6e8453

@vbaranov vbaranov merged commit 7fb61d8 into develop Nov 6, 2018
@vbaranov vbaranov deleted the poa-autodetect-tokens branch November 6, 2018 14:43
@ghost ghost removed the awaiting for review label Nov 6, 2018
@vbaranov vbaranov mentioned this pull request Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants