(Feature) New color palette for NW account #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
fvictorio
reviewed
Jul 26, 2018
old-ui/lib/icon-factory.js
Outdated
| @@ -37,7 +38,8 @@ IconFactory.prototype.generateIdenticonSvg = function (address, diameter) { | |||
| // creates a new identicon | |||
| IconFactory.prototype.generateNewIdenticon = function (address, diameter) { | |||
| var numericRepresentation = jsNumberForAddress(address) | |||
| var identicon = this.jazzicon(diameter, numericRepresentation) | |||
| this.jazzicon.setColorsPalette(colors) | |||
There was a problem hiding this comment.
Woudln't it make more sense to have this setColorsPalette in the constructor, called just once? Or is there a reason to set it each time an icon is generated?
There was a problem hiding this comment.
@fvictorio makes sense, done, tnx
ui/lib/icon-factory.js
Outdated
| @@ -37,6 +38,7 @@ IconFactory.prototype.generateIdenticonSvg = function (address, diameter) { | |||
| // creates a new identicon | |||
| IconFactory.prototype.generateNewIdenticon = function (address, diameter) { | |||
| var numericRepresentation = jsNumberForAddress(address) | |||
| this.jazzicon.setColorsPalette(colors) | |||
fvictorio
approved these changes
Jul 26, 2018
patitonar
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
jazziconis swaped with npmrockiconto support arbitrary colors palette.