Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Empty pending tx screen after logout/login #93

Merged
merged 3 commits into from
Aug 27, 2018
Merged

Conversation

vbaranov
Copy link
Collaborator

Relates to #68

The root cause of the issue is that context prop contains not the index of pending tx, but the context from the previous screen (current unlocked address), when we attempt to login after logout.

Solution:

  • context prop is replaced with pendingTxIndex prop.
  • if pendingTxIndex is undefined, as in the case from logout/login, it is set to 0. So, the first pending tx will be displayed in the list, if pending txs exist.

Also, view of pending contract creation screen is configured to match the style of pending screen:
Before:

2018-08-23 17 22 03

After:

2018-08-23 16 58 38

@vbaranov vbaranov merged commit 97f01e7 into develop Aug 27, 2018
@ghost ghost removed the awaiting for review label Aug 27, 2018
@vbaranov vbaranov deleted the empty-screen branch August 27, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants