-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) Unlimited amount of custom RPC endpoints #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patitonar I was trying to visualize scrollbar before submitting a PR. And decided not to include visualization, because of some visual artefacts at dropdown opening/closing animation. I would suggest adding visualization in a separate PR. |
@vbaranov or custom rpc name displayed if there is custom rpc has been added |
yes, it works in such way from the beginning. Could you please create a separate issue for that?
I didn't catch this one. Could you clarify? |
@fvictorio could you take a look to this PR? do you have any concerns? |
Yes, sorry. This looks good. My only comment is that I think the new RPCs should be at the end of the list. Now the list shows the newest first (after |
It makes sense, especially for the big list of custom RPCs and while we have no ability to hide the list of custom RPCs. I added this fix to PR. Thank you. |
…/metamask-extension into increase-amount-of-custom-rpc
Relates to #26
Unlimited numbers of custom RPCs can be added.
Networks dropdown was updated to support vertical scroll.