Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Unlimited amount of custom RPC endpoints #98

Merged
merged 14 commits into from
Sep 7, 2018

Conversation

vbaranov
Copy link
Collaborator

Relates to #26

Unlimited numbers of custom RPCs can be added.
Networks dropdown was updated to support vertical scroll.

Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should display a visible scroll bar, it will help on the user experience
scroll

@vbaranov vbaranov changed the title (Feature) Unlimited amount of custom RPC (Feature) Unlimited amount of custom RPC endpoints Aug 31, 2018
@vbaranov
Copy link
Collaborator Author

@patitonar I was trying to visualize scrollbar before submitting a PR. And decided not to include visualization, because of some visual artefacts at dropdown opening/closing animation. I would suggest adding visualization in a separate PR.

@dennis00010011b
Copy link

@vbaranov
If network is LOCALHOST then
Settings->Current RPC field is empty
screen shot 2018-08-31 at 8 30 47 am

or custom rpc name displayed if there is custom rpc has been added
screen shot 2018-08-31 at 8 31 30 am

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

If network is LOCALHOST then
Settings->Current RPC field is empty

yes, it works in such way from the beginning. Could you please create a separate issue for that?

or custom rpc name displayed if there is custom rpc has been added

I didn't catch this one. Could you clarify?

@vbaranov
Copy link
Collaborator Author

vbaranov commented Sep 6, 2018

@fvictorio could you take a look to this PR? do you have any concerns?

@fvictorio
Copy link

Yes, sorry. This looks good. My only comment is that I think the new RPCs should be at the end of the list. Now the list shows the newest first (after Localhost 8545). But this is something that can be done in a separate PR.

@vbaranov
Copy link
Collaborator Author

vbaranov commented Sep 7, 2018

My only comment is that I think the new RPCs should be at the end of the list. Now the list shows the newest first (after Localhost 8545). But this is something that can be done in a separate PR.

It makes sense, especially for the big list of custom RPCs and while we have no ability to hide the list of custom RPCs. I added this fix to PR. Thank you.

@vbaranov vbaranov merged commit 946bb78 into develop Sep 7, 2018
@ghost ghost removed the awaiting for review label Sep 7, 2018
@vbaranov vbaranov deleted the increase-amount-of-custom-rpc branch September 7, 2018 16:17
This was referenced Sep 7, 2018
@vbaranov vbaranov mentioned this pull request Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants