Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more console.log #189

Open
lautarodragan opened this issue Jun 28, 2018 · 0 comments
Open

No more console.log #189

lautarodragan opened this issue Jun 28, 2018 · 0 comments

Comments

@lautarodragan
Copy link
Member

lautarodragan commented Jun 28, 2018

There's a few console.logs lying around in the code base that we haven't converted to PinoJS yet.

They exist in three files:

These few unstructured log messages prevent us from treating the entire output of the application as a sequence of JSON objects, which means we can't do things like npm start | jq 'select(.level == 50)'.

Needs #190
Needs #191
Needs #192

@geoffturk geoffturk added this to the PML1 milestone Nov 21, 2018
@geoffturk geoffturk removed this from the PML1 milestone Nov 29, 2018
@geoffturk geoffturk added ct-z and removed ct-z labels Nov 29, 2018
@geoffturk geoffturk added this to the PML1 milestone Nov 29, 2018
@lautarodragan lautarodragan removed this from the PML1 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants