Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate number of neighbours and number of nodes #80

Closed
abelsiqueira opened this issue Apr 25, 2023 · 0 comments · Fixed by #119
Closed

Differentiate number of neighbours and number of nodes #80

abelsiqueira opened this issue Apr 25, 2023 · 0 comments · Fixed by #119
Labels
tech-debt Tests, documentation, CI, best practices, etc.

Comments

@abelsiqueira
Copy link
Contributor

Currently, we use min_neighbours to be the number of neighbours of a point, but also the number of nodes in a graph. Since the number of nodes should be the POI + neighbours, the relation should actually be "num_nodes = min_neighbours + 1".

Possible solutions:

  • Find the places where we use min_neighbours when we actually mean num_nodes and update accordingly. The tests, in particular, have a few of these.
  • Change the parameter name to min_nodes and update accordingly.
@abelsiqueira abelsiqueira changed the title Align number of neighbours with number of nodes Differentiate number of neighbours and number of nodes Apr 25, 2023
@abelsiqueira abelsiqueira added the tech-debt Tests, documentation, CI, best practices, etc. label Jun 20, 2023
@bart1 bart1 closed this as completed in #119 Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Tests, documentation, CI, best practices, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant