@DependencyClient macro generated initializer is not public

[grennis]

Description

The documentation states that the @DependencyClient macro "generates a public initializer... This is particularly useful when modularizing your dependencies... as you will need a public initializer to create instances of the client", however, the generated initializer is not public.

Checklist

• I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• If possible, I've reproduced the issue using the main branch of this package.
• This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

Given this

@DependencyClient
public struct TestClient {
    var foo: () -> Void
}

I expect to generate

public init(
    foo: @escaping () -> Void
) {
    self.foo = foo
}

Actual behavior

Generated code is:

init(
    foo: @escaping () -> Void
) {
    self.foo = foo
}

Steps to reproduce

Please see example above.

Dependencies version information

1.6.3 (tested main branch also)

Destination operating system

iOS 18

Xcode version information

16.2

Swift Compiler version information

swift-driver version: 1.115.1 Apple Swift version 6.0.3 (swiftlang-6.0.3.1.10 clang-1600.0.30.1)

[mbrandonw]

Hi @grennis, the initializer is as public as the non-defaulted fields it holds onto. So this will generate a public initializer:

@DependencyClient
public struct TestClient {
  public var foo: () -> Void
}

You can see this in action in some of our macro tests starting here. To us this makes the most sense because why would you want to publicly be able to configure a closure that cannot be publicly invoked?

Since this isn't an issue with the library I am going to convert it to a discussion. Please feel free to continue the conversation over there!

[grennis]

Makes sense, thank you