Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to diffTool? #780

Closed
JackYoustra opened this issue Sep 26, 2023 · 3 comments
Closed

Enhancements to diffTool? #780

JackYoustra opened this issue Sep 26, 2023 · 3 comments

Comments

@JackYoustra
Copy link

My current workflow for image snapshot tests is usually imagemagik's compare tool, so I'll have a command like

compare "1.png" "2.png" png:- | open -a Preview.app -f

Unfortunately, the framework only lets me specify the "compare" step instead of providing the rest of the command. I was thinking on changing / adding a closure version of diffTool that'd be able to do this. Is there any interest in this or any ideas on how people would like a more generalized diffTool?

@tisohjung
Copy link

I would appreciate it if anyone can review this PR

#668

@endanke
Copy link

endanke commented Dec 31, 2023

@JackYoustra you can probably make an alias to your command which would take the two parameters and run the whole thing.

@mbrandonw
Copy link
Member

Closed via #867.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants