Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.

Server does not reload after config is modified #57

Open
mal opened this issue Mar 27, 2014 · 3 comments
Open

Server does not reload after config is modified #57

mal opened this issue Mar 27, 2014 · 3 comments

Comments

@mal
Copy link
Contributor

mal commented Mar 27, 2014

I tried fixing this by subscribing the service resources to the restart action when the config changes, but it didn't appear to do the job. supervisorctl reload did, but hopefully there's a better way.

@keen99
Copy link

keen99 commented Nov 12, 2015

...turns out, the reload action that's documented here - https://github.com/poise/supervisor/blame/master/README.md#L61

hasn't been implemented yet - https://github.com/poise/supervisor/blob/master/resources/service.rb#L21

@keen99
Copy link

keen99 commented Nov 12, 2015

there IS an update that is executed though on template change - https://github.com/poise/supervisor/blob/master/providers/service.rb#L99

which seems to work - so not sure what the original problem was.

I got here for a similar case, though - made a change to a supervisor_service() entry and didn't get it applied. going to do more testing...

...cannot reproduce, the service gets reloaded (using supervisorctl update) and restarted every time the .conf changes.

there is still the matter of the missing :reload action - @coderanger thoughts on that noah? should it just be dropped from the readme, or should that action be added? I have PR that should work lined up..

@keen99
Copy link

keen99 commented Nov 12, 2015

oh - I bet this was the OP's problem. -supervisord- config changes (via attributes) dont trigger an update

seems like the service definitions -
https://github.com/poise/supervisor/blob/master/recipes/default.rb#L92
https://github.com/poise/supervisor/blob/master/recipes/default.rb#L116

should subscribe against https://github.com/poise/supervisor/blob/master/recipes/default.rb#L41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants