Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Image Box heading to have a working link even without an image #2854

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

Jaska
Copy link
Contributor

@Jaska Jaska commented Nov 28, 2017

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2017

CLA assistant check
All committers have signed the CLA.

@KingYes
Copy link
Member

KingYes commented Jan 22, 2018

It does not make sense to display links using the Image Box widget without the image itself.

@KingYes KingYes closed this Jan 22, 2018
@Jaska
Copy link
Contributor Author

Jaska commented Jan 22, 2018

@KingYes
Then why does the text appear even without the image?

I think it does make sense for Elementor widgets to function properly even without all fields filled. A fallback.

If you look at my commit, it really is a simple fix for (what I think is just) coding mistake - I just moved existing code.

@KingYes KingYes changed the base branch from master to release/1.9.4 February 7, 2018 11:47
@KingYes KingYes reopened this Feb 7, 2018
@KingYes KingYes merged commit 6f0cc2b into elementor:release/1.9.4 Feb 7, 2018
@KingYes
Copy link
Member

KingYes commented Feb 7, 2018

@Jaska We have further looked into this and apparently you were right.
We will release a fix for it in the upcoming update.
Thanks for your input.

@Jaska
Copy link
Contributor Author

Jaska commented Feb 7, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants