From b0145cc7e3f8a9ce9fa42659c66ad84a2bd18acf Mon Sep 17 00:00:00 2001 From: nameexhaustion Date: Thu, 12 Sep 2024 19:08:51 +1000 Subject: [PATCH] refactor: Remove unused feature flags from polars-mem-engine (#18679) --- crates/polars-lazy/Cargo.toml | 2 +- crates/polars-mem-engine/Cargo.toml | 21 +++++-------------- .../src/executors/scan/mod.rs | 2 +- crates/polars-stream/Cargo.toml | 4 ++-- 4 files changed, 9 insertions(+), 20 deletions(-) diff --git a/crates/polars-lazy/Cargo.toml b/crates/polars-lazy/Cargo.toml index a3efd659a77f..333fdc1211d2 100644 --- a/crates/polars-lazy/Cargo.toml +++ b/crates/polars-lazy/Cargo.toml @@ -220,7 +220,7 @@ meta = ["polars-plan/meta"] pivot = ["polars-core/rows", "polars-ops/pivot", "polars-plan/pivot"] top_k = ["polars-plan/top_k"] semi_anti_join = ["polars-plan/semi_anti_join"] -cse = ["polars-plan/cse", "polars-mem-engine/cse"] +cse = ["polars-plan/cse"] propagate_nans = ["polars-plan/propagate_nans", "polars-expr/propagate_nans"] coalesce = ["polars-plan/coalesce"] regex = ["polars-plan/regex"] diff --git a/crates/polars-mem-engine/Cargo.toml b/crates/polars-mem-engine/Cargo.toml index aa3d7dc5fd0a..d3af71449cd4 100644 --- a/crates/polars-mem-engine/Cargo.toml +++ b/crates/polars-mem-engine/Cargo.toml @@ -36,28 +36,17 @@ json = ["polars-io/json", "polars-plan/json", "polars-json"] csv = ["polars-io/csv", "polars-plan/csv"] cloud = ["async", "polars-plan/cloud", "tokio", "futures"] parquet = ["polars-io/parquet", "polars-plan/parquet"] -temporal = [ - "dtype-datetime", - "dtype-date", - "dtype-time", - "dtype-i8", - "dtype-i16", - "dtype-duration", - "polars-plan/temporal", -] -dtype-array = ["polars-plan/dtype-array", "polars-ops/dtype-array"] dtype-categorical = ["polars-plan/dtype-categorical"] -dtype-date = ["polars-plan/dtype-date", "polars-time/dtype-date", "temporal"] -dtype-datetime = ["polars-plan/dtype-datetime", "polars-time/dtype-datetime", "temporal"] +dtype-date = ["polars-plan/dtype-date", "polars-time/dtype-date"] +dtype-datetime = ["polars-plan/dtype-datetime", "polars-time/dtype-datetime"] dtype-decimal = ["polars-plan/dtype-decimal"] -dtype-duration = ["polars-plan/dtype-duration", "polars-time/dtype-duration", "temporal"] +dtype-duration = ["polars-plan/dtype-duration", "polars-time/dtype-duration"] dtype-i16 = ["polars-plan/dtype-i16"] dtype-i8 = ["polars-plan/dtype-i8"] dtype-struct = ["polars-plan/dtype-struct", "polars-ops/dtype-struct"] -dtype-time = ["polars-plan/dtype-time", "polars-time/dtype-time", "temporal"] +dtype-time = ["polars-plan/dtype-time", "polars-time/dtype-time"] dtype-u16 = ["polars-plan/dtype-u16"] dtype-u8 = ["polars-plan/dtype-u8"] object = ["polars-core/object"] -dynamic_group_by = ["polars-plan/dynamic_group_by", "polars-time", "temporal", "polars-expr/dynamic_group_by"] +dynamic_group_by = ["polars-plan/dynamic_group_by", "polars-time", "polars-expr/dynamic_group_by"] asof_join = ["polars-plan/asof_join", "polars-time", "polars-ops/asof_join"] -cse = ["polars-plan/cse"] diff --git a/crates/polars-mem-engine/src/executors/scan/mod.rs b/crates/polars-mem-engine/src/executors/scan/mod.rs index 1b46d40b9044..59a98ea800d7 100644 --- a/crates/polars-mem-engine/src/executors/scan/mod.rs +++ b/crates/polars-mem-engine/src/executors/scan/mod.rs @@ -21,7 +21,7 @@ pub(crate) use ndjson::JsonExec; pub(crate) use parquet::ParquetExec; #[cfg(any(feature = "ipc", feature = "parquet", feature = "csv"))] use polars_io::predicates::PhysicalIoExpr; -#[cfg(any(feature = "parquet", feature = "csv", feature = "ipc", feature = "cse"))] +#[cfg(any(feature = "parquet", feature = "csv", feature = "ipc"))] use polars_io::prelude::*; use polars_plan::global::_set_n_rows_for_scan; diff --git a/crates/polars-stream/Cargo.toml b/crates/polars-stream/Cargo.toml index 4cec6b590e81..b1a70997a3c3 100644 --- a/crates/polars-stream/Cargo.toml +++ b/crates/polars-stream/Cargo.toml @@ -28,9 +28,9 @@ polars-core = { workspace = true } polars-error = { workspace = true } polars-expr = { workspace = true, features = ["dtype-full"] } # TODO: feature gate -polars-mem-engine = { workspace = true, features = ["parquet", "csv", "json", "ipc", "cloud", "python", "temporal", "dtype-categorical", "dtype-i8", "dtype-i16", "dtype-u8", "dtype-u16", "dtype-decimal", "dtype-struct", "object"] } +polars-mem-engine = { workspace = true, features = ["parquet", "csv", "json", "ipc", "cloud", "python", "dtype-categorical", "dtype-i8", "dtype-i16", "dtype-u8", "dtype-u16", "dtype-decimal", "dtype-struct", "object"] } polars-parquet = { workspace = true } -polars-plan = { workspace = true, features = ["parquet", "csv", "json", "ipc", "cloud", "python", "serde", "temporal", "dtype-categorical", "dtype-i8", "dtype-i16", "dtype-u8", "dtype-u16", "dtype-decimal", "dtype-struct", "object"] } +polars-plan = { workspace = true, features = ["parquet", "csv", "json", "ipc", "cloud", "python", "serde", "dtype-categorical", "dtype-i8", "dtype-i16", "dtype-u8", "dtype-u16", "dtype-decimal", "dtype-struct", "object"] } [build-dependencies] version_check = { workspace = true }