Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues due to new project structure #10199

Closed
ritchie46 opened this issue Jul 31, 2023 · 4 comments
Closed

issues due to new project structure #10199

ritchie46 opened this issue Jul 31, 2023 · 4 comments
Assignees
Labels
accepted Ready for implementation internal An internal refactor or improvement

Comments

@ritchie46
Copy link
Member

I think we need to revert the new project structure until these problems are solved.

Currently there are 2 problems.

  1. the build.rs file isn't applied anymore. Local pre-commit will fail because of new lints. They are somehow not triggered in CI.
  2. The integation tests fail locally, but not in CI. cargo t --features=test --test=it has failed tests locally that were not happening before.

I think those changes are related to the new structure.

@stinodego, tuning you in here.

@stinodego
Copy link
Member

I'll take a look at these, thanks. Just revert for now!

@ritchie46
Copy link
Member Author

No opposition. If the issues are resolved happy to gor forward with this.

@stinodego
Copy link
Member

stinodego commented Jul 31, 2023

The reason for the discrepancy between clippy in the CI and locally is because the CI runs clippy with default features on stable. Locally it now runs clippy with default features on nightly. So there's the issue.

Looking into build.rs atm.

@stinodego stinodego added the accepted Ready for implementation label Jul 31, 2023
@stinodego stinodego added the internal An internal refactor or improvement label Jul 31, 2023
@stinodego
Copy link
Member

I believe this can now be closed.

The reason for these issues popping up is that we're now operating on a Cargo workspace instead of on a single crate in a Cargo workspace. There are a few things to iron out still, I'll keep working on those. Feel free to tag me in this issue if you run into anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement
Projects
Archived in project
Development

No branches or pull requests

2 participants