Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failure due to test_streaming_unique.py::test_streaming_out_of_core_unique #13970

Closed
mcrumiller opened this issue Jan 24, 2024 · 3 comments
Closed
Labels
bug Something isn't working python Related to Python Polars

Comments

@mcrumiller
Copy link
Contributor

mcrumiller commented Jan 24, 2024

Ref #13526. Sorry, there's another one :(

Reproducible example

pytest -m "" tests/unit/streaming/test_streaming_unique.py::test_streaming_out_of_core_unique

Log output

(.venv) mcrumiller@Saline-PC:~/projects/polars/py-polars$ pytest -m "" tests/unit/streaming/test_streaming_unique.py::test_streaming_out_of_core_unique
=================================================================================================================================================== test session starts ===================================================================================================================================================
platform linux -- Python 3.11.3, pytest-7.4.0, pluggy-1.3.0
rootdir: /home/mcrumiller/projects/polars/py-polars
configfile: pyproject.toml
plugins: hypothesis-6.92.1, xdist-3.5.0, cov-4.1.0
collected 1 item                                                                                                                                                                                                                                                                                                          

tests/unit/streaming/test_streaming_unique.py F                                                                                                                                                                                                                                                                     [100%]

======================================================================================================================================================== FAILURES =========================================================================================================================================================
____________________________________________________________________________________________________________________________________________ test_streaming_out_of_core_unique ____________________________________________________________________________________________________________________________________________
tests/unit/streaming/test_streaming_unique.py:28: in test_streaming_out_of_core_unique
    df1 = q.join(q.head(1000), how="cross").unique().collect(streaming=True)
polars/lazyframe/frame.py:1730: in collect
    return wrap_df(ldf.collect())
E   pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: SchemaMismatch(ErrString("invalid series dtype: expected `BinaryOffset`, got `binary`"))
-------------------------------------------------------------------------------------------------------------------------------------------------- Captured stdout call ---------------------------------------------------------------------------------------------------------------------------------------------------
run UnionExec
UNION: `parallel=false` union is run sequentially
run UdfExec
-------------------------------------------------------------------------------------------------------------------------------------------------- Captured stderr call ---------------------------------------------------------------------------------------------------------------------------------------------------
file < 128 rows, no statistics determined
no. of chunks: 1 processed by: 1 threads.
file < 128 rows, no statistics determined
no. of chunks: 1 processed by: 1 threads.
file < 128 rows, no statistics determined
no. of chunks: 1 processed by: 1 threads.
file < 128 rows, no statistics determined
no. of chunks: 1 processed by: 1 threads.
file < 128 rows, no statistics determined
no. of chunks: 1 processed by: 1 threads.
RUN STREAMING PIPELINE
df -> cross_join_sink
RefCell { value: [df -> placeholder -> slice_sink -> fast_projection -> cross_join_sink, df -> cross_join_sink, df -> placeholder -> slice_sink -> fast_projection -> slice_sink -> placeholder -> re-project-sink -> ordered_sink] }
OOC group_by started
Temporary directory path in use: /tmp
OOC group_by started
Temporary directory path in use: /tmp
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
OOC group_by started
process partition 0 during generic-group_by-source
thread '<unnamed>' panicked at crates/polars-pipe/src/executors/sinks/group_by/generic/mod.rs:97:44:
called `Result::unwrap()` on an `Err` value: SchemaMismatch(ErrString("invalid series dtype: expected `BinaryOffset`, got `binary`"))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
================================================================================================================================================= short test summary info =================================================================================================================================================
FAILED tests/unit/streaming/test_streaming_unique.py::test_streaming_out_of_core_unique - pyo3_runtime.PanicException: called `Result::unwrap()` on an `Err` value: SchemaMismatch(ErrString("invalid series dtype: expected `BinaryOffset`, got `binary`"))
==================================================================================================================================================== 1 failed in 6.73s ====================================================================================================================================================

Issue description

This test is failing consistently.

Expected behavior

Should pass.

Installed versions

main

@mcrumiller mcrumiller added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Jan 24, 2024
@mcrumiller
Copy link
Contributor Author

I think @ritchie46 is our best hope as it appears to be related to the new string implementation.

@stinodego
Copy link
Member

Actually I broke this in #13961 by moving the pytest markers. Should be fixed with #13974.

If you can manage to reproduce the error outside of pytest, I'd be interested to see a bug report though!

@stinodego stinodego removed the needs triage Awaiting prioritization by a maintainer label Jan 25, 2024
@mcrumiller
Copy link
Contributor Author

Ahh good, glad it was not a serious issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Related to Python Polars
Projects
None yet
Development

No branches or pull requests

2 participants