Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features json and lazy together implicitly require parquet to compile #18416

Closed
2 tasks done
rben01 opened this issue Aug 28, 2024 · 2 comments
Closed
2 tasks done

Features json and lazy together implicitly require parquet to compile #18416

rben01 opened this issue Aug 28, 2024 · 2 comments
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars

Comments

@rben01
Copy link
Contributor

rben01 commented Aug 28, 2024

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

Cargo.toml

[dependencies]
	polars = { version = "0.42", features = ["json", "lazy"] }

main.rs

use polars::prelude::*;
fn main() {}

Log output

Compiling other deps...
   Compiling polars-plan v0.42.0
error[E0412]: cannot find type `CloudOptions` in this scope
   --> /Users/rben01/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-plan-0.42.0/src/plans/functions/count.rs:189:28
    |
189 |     cloud_options: Option<&CloudOptions>,
    |                            ^^^^^^^^^^^^
    |
   ::: /Users/rben01/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-plan-0.42.0/src/dsl/options.rs:47:1
    |
47  | pub struct JoinOptions {
    | ---------------------- similarly named struct `JoinOptions` defined here
    |
help: a struct with a similar name exists
    |
189 |     cloud_options: Option<&JoinOptions>,
    |                            ~~~~~~~~~~~
help: consider importing this struct
    |
5   + use polars_io::cloud::CloudOptions;
    |

error[E0425]: cannot find function `is_cloud_url` in this scope
   --> /Users/rben01/.cargo/registry/src/index.crates.io-6f17d22bba15001f/polars-plan-0.42.0/src/plans/functions/count.rs:193:42
    |
193 |     let run_async = !paths.is_empty() && is_cloud_url(&paths[0]) || config::force_async();
    |                                          ^^^^^^^^^^^^ not found in this scope
    |
help: consider importing this function
    |
5   + use polars_io::is_cloud_url;
    |

Some errors have detailed explanations: E0412, E0425.
For more information about an error, try `rustc --explain E0412`.
error: could not compile `polars-plan` (lib) due to 2 previous errors

Issue description

With only features json and lazy, compilation fails as shown above. Adding feature parquet makes compilation succeed.

Expected behavior

No combination of features should prevent code from compiling.

Installed versions

[dependencies]
	polars = { version = "0.42", features = ["json", "lazy"] }
@rben01 rben01 added bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars labels Aug 28, 2024
@rob-sil
Copy link
Contributor

rob-sil commented Aug 29, 2024

This looks like the error in #18258, which was fixed in #18305 for the next rust version.

@rben01
Copy link
Contributor Author

rben01 commented Aug 30, 2024

Thanks, I'll close this then.

@rben01 rben01 closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Awaiting prioritization by a maintainer rust Related to Rust Polars
Projects
None yet
Development

No branches or pull requests

2 participants