Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scan_csv PanicException if quote_char is empty string #19099

Closed
2 tasks done
cmdlineluser opened this issue Oct 4, 2024 · 0 comments · Fixed by #19100
Closed
2 tasks done

scan_csv PanicException if quote_char is empty string #19099

cmdlineluser opened this issue Oct 4, 2024 · 0 comments · Fixed by #19100
Assignees
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars

Comments

@cmdlineluser
Copy link
Contributor

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl
pl.scan_csv(b"", quote_char="")
# PanicException: index out of bounds: the len is 0 but the index is 0

Log output

No response

Issue description

Also happens for eol_char

pl.scan_csv(b"", eol_char="")
# PanicException: index out of bounds: the len is 0 but the index is 0

Not sure if comment_prefix needs a check for empty string also:

pl.scan_csv(b"a,b,c\n1,2,3", comment_prefix="").collect() # should be allowed?
# NoDataError: empty CSV

Expected behavior

No panic.

Installed versions

--------Version info---------
Polars:               1.9.0
Index type:           UInt32
Platform:             macOS-13.6.1-arm64-arm-64bit
Python:               3.12.2 (main, Feb  6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
great_tables:         <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
nest_asyncio:         <not installed>
numpy:                1.26.4
openpyxl:             <not installed>
pandas:               2.2.1
pyarrow:              15.0.2
pydantic:             <not installed>
pyiceberg:            <not installed>
sqlalchemy:           <not installed>
torch:                <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>
@cmdlineluser cmdlineluser added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Oct 4, 2024
@c-peters c-peters added the accepted Ready for implementation label Oct 6, 2024
@c-peters c-peters moved this to Done in Backlog Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants