Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum with AggregateFunction is done with different data type #5217

Closed
cannero opened this issue Oct 15, 2022 · 2 comments · Fixed by #5224
Closed

Sum with AggregateFunction is done with different data type #5217

cannero opened this issue Oct 15, 2022 · 2 comments · Fixed by #5224

Comments

@cannero
Copy link
Contributor

cannero commented Oct 15, 2022

With PR #5170 the data types were swapped in one part of convert_to_hash_agg:

image

Unsigned to signed and vice versa. To me that seems to be wrong or is there are reason for it?

polars/polars/polars-lazy/polars-pipe/src/executors/sinks/groupby/aggregates/convert.rs

Line 81 in 926b5a2

pub fn convert_to_hash_agg<F>(

@ritchie46
Copy link
Member

Yeap.. that's wrong. Can you make PR?

@cannero
Copy link
Contributor Author

cannero commented Oct 15, 2022

Yes, I will open a PR.

@ritchie46 ritchie46 mentioned this issue Oct 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rust, python): fix pipeline dtypes pola-rs/polars
2 participants
@ritchie46 @cannero