Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Use workspace package info / organize dependencies section #10279

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Aug 3, 2023

Changes:

  • Define shared package info on the workspace level and use it across our crates
  • Move the dependencies section before the features section everywhere (this was inconsistent) according to the manifest format.

This doesn't impact anything except for being a bit nicer to look at. I'd like to move some dependency version definitions to the workspace level as well - I'll do that in a separate PR.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Aug 3, 2023
Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much more well organized!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants