Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust): fix build for wasm #9502

Merged
merged 4 commits into from
Aug 16, 2023
Merged

fix(rust): fix build for wasm #9502

merged 4 commits into from
Aug 16, 2023

Commits on Aug 11, 2023

  1. fix(rust) fix build for wasm 

    Fixes issue #8783, where v0.29 broke the build for wasm.
In addition to fixing the build, this adds a CI test to prevent
regressions like this in the future.

Relatedly there's an issue for the `home` crate rust-lang/cargo#12297 to
make it compile for wasm. The previously used crate there, `dirs`,
_does_ support wasm (just returning None for the home dir).
    @lorepozo
    lorepozo committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bc27df4 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. move wasm check to Makefile

    @lorepozo
    lorepozo committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    52d8a49 View commit details
    Browse the repository at this point in the history

  2. use excluded features when checking wasm

    @lorepozo
    lorepozo committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    afd30de View commit details
    Browse the repository at this point in the history

  3. update github workflow steps for check-wasm

    @lorepozo
    lorepozo committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    5c5bbbb View commit details
    Browse the repository at this point in the history