Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & typegen deprecation flag for RPCs #5241

Closed
athei opened this issue Sep 27, 2022 · 5 comments · Fixed by #5244
Closed

Add & typegen deprecation flag for RPCs #5241

athei opened this issue Sep 27, 2022 · 5 comments · Fixed by #5244

Comments

@athei
Copy link

athei commented Sep 27, 2022

We will soon remove the contract RPCs from substrate as their are redundant. Please consider removing or deprecating them here and pointing users to state_call instead.

@jacogr
Copy link
Member

jacogr commented Sep 27, 2022

The API contract interfaces itself doesn't use them, it has been converted to state_call, see #5107.

Like any other RPC, they could be available or not available, so the API will just decorate the interfaces are existing on rpc_methods, if they are not available, they won't be decorated.

@athei
Copy link
Author

athei commented Sep 27, 2022

Makes sense. However, I was hoping we could easily add some deprecation attribute there or something because they are not expected to be there going forward. Otherwise users might think they need to add them when in fact they should just use state_call. If they use this stuff directly instead of the abstraction.

@jacogr
Copy link
Member

jacogr commented Sep 27, 2022

Can certainly add a deprecation attribute (there is no such thing), but this is actually a massive undertaking with typegen and reworking the interfaces. So we are literally months out (probably Q1 2023) before that can even be looked at, just judging by what is in the queue atm.

@jacogr jacogr changed the title Remove contract RPCs Add & typegen deprecation flag for RPCs Sep 27, 2022
@jacogr
Copy link
Member

jacogr commented Sep 27, 2022

In addition to contracts, this would also affect actual RPCs marked as deprecated, eg. state_getPairs (this obviously only helps TS & IDE developers, the rest won't see this marking at all)

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants