Add more complex namespaced contracts & test cases for them #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jan 20, 2022
| const latest = v1ToLatest(registry, contract.asV1); | ||
| expect( | ||
| latest.spec.messages.map(({ label }) => label.toString()) | ||
| ).toEqual(['PSP22Metadata,token_name', 'PSP22Metadata,token_symbol', 'PSP22Metadata,token_decimals', 'PSP22Mintable,mint', |
There was a problem hiding this comment.
Suggested change
| ).toEqual(['PSP22Metadata,token_name', 'PSP22Metadata,token_symbol', 'PSP22Metadata,token_decimals', 'PSP22Mintable,mint', | |
| ).toEqual(['PSP22Metadata::token_name', 'PSP22Metadata::token_symbol', 'PSP22Metadata::token_decimals', 'PSP22Mintable::mint', |
I believe the above is how it is now in master, let's see what the CI tests throw out.
jacogr
reviewed
Jan 20, 2022
| expect( | ||
| latest.spec.messages.map(({ label }) => label.toString()) | ||
| ).toEqual(['PSP22Metadata,token_name', 'PSP22Metadata,token_symbol', 'PSP22Metadata,token_decimals', 'PSP22Mintable,mint', | ||
| 'PSP22,decrease_allowance', 'PSP22,transfer', 'PSP22,approve', 'PSP22,allowance', 'PSP22,transfer_from', 'PSP22,balance_of', 'PSP22,increase_allowance', |
There was a problem hiding this comment.
Suggested change
| 'PSP22,decrease_allowance', 'PSP22,transfer', 'PSP22,approve', 'PSP22,allowance', 'PSP22,transfer_from', 'PSP22,balance_of', 'PSP22,increase_allowance', | |
| 'PSP22::decrease_allowance', 'PSP22::transfer', 'PSP22::approve', 'PSP22::allowance', 'PSP22::transfer_from', 'PSP22::balance_of', 'PSP22::increase_allowance', |
jacogr
reviewed
Jan 20, 2022
| latest.spec.messages.map(({ label }) => label.toString()) | ||
| ).toEqual(['PSP22Metadata,token_name', 'PSP22Metadata,token_symbol', 'PSP22Metadata,token_decimals', 'PSP22Mintable,mint', | ||
| 'PSP22,decrease_allowance', 'PSP22,transfer', 'PSP22,approve', 'PSP22,allowance', 'PSP22,transfer_from', 'PSP22,balance_of', 'PSP22,increase_allowance', | ||
| 'PSP22,total_supply', 'pause', 'unpause']); |
There was a problem hiding this comment.
Suggested change
| 'PSP22,total_supply', 'pause', 'unpause']); | |
| 'PSP22::total_supply', 'pause', 'unpause']); |
jacogr
reviewed
Jan 20, 2022
jacogr
reviewed
Jan 20, 2022
jacogr
reviewed
Jan 20, 2022
jacogr
reviewed
Jan 20, 2022
jacogr
reviewed
Jan 20, 2022
jacogr
approved these changes
Jan 20, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds complex contracts with namespaced methods (contained either within
#[ink::trait_definiton]or#[ink(namespace)].