Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project can't be included as a sub-project of another CMake project #15

Open
mschuckmann opened this issue Jun 20, 2023 · 0 comments
Open

Comments

@mschuckmann
Copy link

mschuckmann commented Jun 20, 2023

Attempting to use CMakes fetchcontent() facility or simply including this project as a sub-project (or dependency) of another CMake project fails due to incorrect use of CMAKE_SOURCE_DIR in when setting up the include paths in src/CMakeLists.txt

The use of CMAKE_SOURCE_DIR should be replaced with CMAKE_PROJECT_SOURCE_DIR.
Additionally the use of CMAKE_CURRENT_*_DIR variables should probably be changed to use the CMAKE_PROJECT_*_DIR versions.

There maybe other similar changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant