Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Gradle builds target dependencies for target modules with no source after change. #131

Closed
1 task
fuzzyweapon opened this issue Feb 28, 2019 · 0 comments
Closed
1 task
Assignees
Labels
bug bug-external bugs we are tracking but are not caused by us external-needs-filing ext. bug needs filing w/source & linking (triage) scaffolding build/distro/CI/etc

Comments

@fuzzyweapon
Copy link
Contributor

fuzzyweapon commented Feb 28, 2019

EX:

  • acornui-build-tasks only has source for jvm, but in order to use the MPP plugin, we are currently defining a js target as well.
  • acornui-build-tasks-js has the kotlin-stdlib-js as a dependency.
  • actual -jvm dependencies are declared in the common target
  1. Make a change in jvm src.
  2. Execute publishToLocalMaven from acornui-build-tasks.
  3. Observe gradle calling the acornui-core-js compile task.

Current speculation is it's unclear whether we can fix this in a clean way. The possible solution below may not be fully supported and requires us to do some things I wouldn't be happy for us to own in the long run, and I think regardless, we'll want to escalate something with jetbrains about smoothing this out.

SPIKE: We can try specifying specific target configurations in our project dependency declarations for only the targets we have actual source for, but this is untested. It's unclear how this might interfere with other aspects of the build or if it will even be fully compatible with the MPP plugin.

  • File any long term jb bugs necessary
@fuzzyweapon fuzzyweapon added bug scaffolding build/distro/CI/etc labels Feb 28, 2019
@fuzzyweapon fuzzyweapon self-assigned this Feb 28, 2019
@fuzzyweapon fuzzyweapon added bug-external bugs we are tracking but are not caused by us external-needs-filing ext. bug needs filing w/source & linking (triage) labels Apr 9, 2019
@nbilyk nbilyk closed this as completed in b7826da Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug bug-external bugs we are tracking but are not caused by us external-needs-filing ext. bug needs filing w/source & linking (triage) scaffolding build/distro/CI/etc
Projects
None yet
Development

No branches or pull requests

1 participant