From 23f31e0008fcd95fd7f917a309df23865e1cd9e3 Mon Sep 17 00:00:00 2001 From: Nate Beauregard Date: Wed, 18 Sep 2024 12:33:28 -0400 Subject: [PATCH] Add new error message for unrecognized cross domain messages --- x/rollup/keeper/deposits.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/x/rollup/keeper/deposits.go b/x/rollup/keeper/deposits.go index 66e5ab08..aeafdea6 100644 --- a/x/rollup/keeper/deposits.go +++ b/x/rollup/keeper/deposits.go @@ -122,9 +122,10 @@ func (k *Keeper) processL1UserDepositTxs( // Do not return an error if the cross domain message can't be parsed or executed to keep the // state transitions from the other deposit txs if err != nil { - // TODO: should this log be a warning or error? ctx.Logger().Warn("Failed to parse or execute cross domain message", "err", err) - } else if erc20mintEvent != nil { + } else if erc20mintEvent == nil { + ctx.Logger().Warn("Cross domain message not recognized", "txData", tx.Data()) + } else { mintEvents = append(mintEvents, *erc20mintEvent) } }