Skip to content

Commit

Permalink
Update deployed bytecode comparison (ethereum-optimism#8984)
Browse files Browse the repository at this point in the history
  • Loading branch information
spacesailor24 authored and dshiell committed Jan 22, 2024
1 parent bd70f6b commit 1f1918d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions op-bindings/bindgen/remote_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,14 @@ func (generator *BindGenGeneratorRemote) create2DeployerHandler(contractMetadata
return err
}

// We're expecting the bytecode for Create2Deployer to not match the deployment on OP,
// because we're predeploying a modified version of Create2Deployer that has not yet been
// deployed to OP.
// We're expecting the initialization bytecode for Create2Deployer to not match the init code on OP,
// because the deployment on OP has been overwritten by the Canyon hardfork, and the init code
// Etherscan returns for the OP deployment is from the initial outdated deployment.
// For context: https://github.com/ethereum-optimism/op-geth/pull/126
if err := generator.CompareInitBytecodeWithOp(contractMetadata, false); err != nil {
return fmt.Errorf("%s: %w", contractMetadata.Name, err)
}
if err := generator.CompareDeployedBytecodeWithOp(contractMetadata, false); err != nil {
if err := generator.CompareDeployedBytecodeWithOp(contractMetadata, true); err != nil {
return fmt.Errorf("%s: %w", contractMetadata.Name, err)
}

Expand Down

0 comments on commit 1f1918d

Please sign in to comment.