Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types change causes build error in Symfonia #523

Closed
kozabrada123 opened this issue Jul 13, 2024 · 2 comments · Fixed by #533
Closed

Types change causes build error in Symfonia #523

kozabrada123 opened this issue Jul 13, 2024 · 2 comments · Fixed by #533

Comments

@kozabrada123
Copy link
Member

I'm guilty of this of course, just opening it up to an issue to track it better

Pr #514 causes a build error in Symfonia by changing pub theme_colors: Option<Vec<u8>>, to pub theme_colors: Option<Vec<u32>>,, since Vec<u8> can be encoded by Sqlx but Vec<u32> cannot.

An ideal solution to this would bring include a new type for theme colors, with a custom Sqlx encoding implementation. Note that the most accurate representation of theme colors is likely (u32, u32) or [u32; 2]

@kozabrada123
Copy link
Member Author

Atm this issue prevents Symfonia from updating chorus past commit d591616

@bitfl0wer bitfl0wer self-assigned this Jul 26, 2024
@bitfl0wer bitfl0wer linked a pull request Jul 26, 2024 that will close this issue
bitfl0wer added a commit that referenced this issue Jul 26, 2024
Related to #523, changes `theme_colors` property on `User` and
`PublicUser` to be of type `(u32, u32)`
@bitfl0wer
Copy link
Member

Fixed by #533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants