Full wasm support with wasm-bindgen-futures
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-bindgen-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the necessary patches to correctly pass (all but two) tests when compiling for wasm32-unknown-unknown.
2 tests have been disabled for wasm at the moment: test messages::search_messages and test messages::send_message_attachment. These two tests currently rely on
std::fsto grab a file to send/search for using chorus. This is not possible on wasm32-unknown, because this target does not have a Filesystem, and does not emulate on either. These two tests should be patched, but this should be good enough for now.