-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the gateway to properly accept close frames #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I have seen this comment in multiple files now: Would it perhaps be possible and feasible to convert wasm-stream and tungstenite messages into the same type? that way, we would not have to differentiate between the two in multiple files
That's how we used to do it; probably no, unless we have another task that just listens for ws_stream_wasm errors |
How the messages are is represented currently: non error messages from tungstenite and ws_stream_wasm can both be |
I meaaaan, that could work! |
I think this is nicer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes! My only issue with them would be what I already mentioned, but other than that it looks great!
also introduces a test for receiving the close codes.
Differentiates the wasm and tungstenite gateways a bit more.
The same thing should be done for the voice gateway, I'll likely add it to this pr if the mod to the normal gateway is okay