Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release withserialized files #235

Open
cbrzn opened this issue Sep 1, 2023 · 0 comments
Open

Fix release withserialized files #235

cbrzn opened this issue Sep 1, 2023 · 0 comments

Comments

@cbrzn
Copy link
Collaborator

cbrzn commented Sep 1, 2023

Serialized WASM modules are being created for the embedded wraps; being the reason that it is faster to initialize the WASM Package, hence, improving the dev exp.

At first, we were committing the files but we got this error: https://github.com/polywrap/rust-client/actions/runs/6036435666/job/16379292848#step:4:2154. Meaning that, when running cargo publish it is modifying somehow the serialized modules; hence, throwing this error.

Then, a PR to ignore the serialized files was merged #231 and now we're having this error: https://github.com/polywrap/rust-client/actions/runs/6037828180/job/16383805428#step:4:2603. Meaning that, when running cargo publish the serialized files where created but they haven't been committed

We can:
a) Check why the serialized file is modified in the cargo publish process, this would fix situation #1
b) Keep ignoring the files and allow the crates to be pushed with non-committed files, this would fix situation #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant