Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MacOS platform version setting #4469

Closed
SeanTAllen opened this issue Oct 28, 2023 · 1 comment · Fixed by #4471
Closed

Clean up MacOS platform version setting #4469

SeanTAllen opened this issue Oct 28, 2023 · 1 comment · Fixed by #4471
Assignees
@chalcolith
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@SeanTAllen
Copy link
Member

When we merged #4466 to fix X86 MacOS linking, we ended up spreading the "13.0.0" minimum platform version across a number of files. As discussed on that PR, we want to clean that up and use a single define.

CMake knowledge required here.
@SeanTAllen SeanTAllen added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request labels Oct 28, 2023
@SeanTAllen
Copy link
Member Author

@chalcolith can you take this one?

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 28, 2023
@chalcolith chalcolith self-assigned this Oct 30, 2023
@chalcolith chalcolith mentioned this issue Oct 30, 2023
Merged
@SeanTAllen SeanTAllen removed help wanted Extra attention is needed discuss during sync Should be discussed during an upcoming sync labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalcolith chalcolith

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set MacOS platform version in one place ponylang/ponyc
3 participants
@chalcolith @SeanTAllen @ponylang-main