-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom assertion mechanism with backtrace printing #1610
Conversation
373eca0
to
5fa5af2
Compare
The tests are failing correctly. I'll update the PR to remove the assertion. |
5fa5af2
to
680c4d5
Compare
Very odd: debug build on Windows is failing to find some symbols at link time. |
The stack trace functions are in an additional library:
|
680c4d5
to
61495c0
Compare
Thanks @kulibali. I've updated the PR. |
e59c7e2
to
5f4cd0f
Compare
Conflicts resolved. |
This change will allow getting more complete reports from assertion failures. This will smooth the the bug report process, as users won't have to get a backtrace from a debugger. As part of this change, assertions are now enabled in release builds of the compiler, as discussed in ponylang#1553. They still are disabled in release builds of the runtime. In the future, this system could be extended with even more precise information like line numbers. Parsing the debug information of the executables and libraries will be required for this. Closes ponylang#1553.
5f4cd0f
to
510a2df
Compare
And errors fixed. |
I'm still compiling with
|
I guess putting a define on |
This change will allow getting more complete reports from assertion failures. This will smooth the the bug report process, as users won't have to get a backtrace from a debugger. As part of this change, assertions are now enabled in release builds of the compiler, as discussed in #1553. They still are disabled in release builds of the runtime.
In the future, this system could be extended with even more precise information like line numbers. Parsing the debug information of the executables and libraries will be required for this.
Closes #1553.
PS: The tests should all fail, I've added an always firing assertion to check if the backtrace report works correctly on all systems.