-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GCC7 on Linux #2134
Support GCC7 on Linux #2134
Conversation
I set up a Sid VM and verified both the issue and the fix. I'll have a different PR for instructions for building on Sid as I had to figure that out. However there is then a problem with building pony programs.
|
-latomic needs to be added during the linking phase as well |
c695f4a
to
670ed74
Compare
Ok, I have fix for linux. verifying it passes our CI. Going to check to see if fixes freebsd issue as well. |
Our only GCC7 issue appears to that it needs to be linked against libatomic explicitly. This commit links to libamotic explicitly on any Linux platform regardless of compiler version. Closes #1756
670ed74
to
a1f32f4
Compare
This doesnt work on FreeBSD. I've updated the PR to be linux only. If this passes CI, its good to merge. |
Our only GCC7 issue appears to that it needs to be linked against
libatomic explicitly. This commit links to libamotic explicitly on any
Linux platform regardless of compiler version.
Closes #1756