Fix Iter.take to handle infinite iterator #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
added
the
changelog - fixed
|
This feels like something that it would be good to have a test for. Is it something we could do with a test that has a timeout? If it doesn't complete within X, fail the test? |
|
@SeanTAllen the test that I added segfaults prior to this change, though a timeout would be better. |
Previously, the `take` method on an infinite stream, such as `Rand`, would cause infinite recursion.
|
@SeanTAllen the test now has a timeout |
SeanTAllen
referenced
this pull request
Sep 6, 2017
Previously, the `take` method on an infinite stream, such as `Rand`, would cause infinite recursion.
ponylang-main
added a commit
that referenced
this pull request
Sep 6, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
takemethod on an infinite stream, such asRand,would cause infinite recursion.