[BUG?]: High memory consumption - spawn too many system threads for image/thumbnail decoding & leaking?

[l-const]

Cosmic-files version:

20f9292

Issue/Bug description:

Steps to reproduce:

Expected behavior:

Other notes:

using heaptrack: https://github.com/KDE/heaptrack

installed with :

dnf install heaptrack

executed:

heaptrack --pid ${pid of cosmic-files}

with initial on startup memory consumption of 48MB as seen from this:

reaching up to and excedding 300MB:

heaptrack overview:

it seems that no memory leak is happening but for the thumnail generation
we create through tokio too manu system threads by calling the clone3 system call

Here is the zipped .zst file that i exported:

heaptrack.cosmic-files.31272.zip

[l-const]

Used top to find the number of threads from the process, there is a variable size of threads , starting with 31 and managed to get up to 43 but then again did go down to 31 again after inactivity, the worrying part is that i managed to reach 1.0 GB memory consumption:

executed:

top -H -p 6880

[l-const]

Update:

1. reached 1.2 GB
2. huge allocation from cosmic_text::shape_fallback and shapeline::layout_to_buffer
3. actual leak in image::dynimage::DynamicImage::thumbnail::thumbnail_exact of 8.5 MB

heaptrack.cosmic-files.28551.zip

actually, cosmic_text seems to be leaking, reported 300MB :

heaptrack.cosmic-files.40307.zip

heaptrack stats:
	allocations:          	9778375
	leaked allocations:   	144634
	temporary allocations:	2224622
Heaptrack finished! Now run the following to investigate the data:

  heaptrack --analyze "/home/kostas/heaptrack.cosmic-files.40307.zst"

[l-const]

[l-const]

I recorded a small video going from 50MB to 350MB:

memory-leak-cosmic-files.webm