Adwaita theme call is non-standard

[fulalas]

As discussed here, cosmic-settings-daemon is assuming GTK3 default theme is adw-gtk3 / adw-gtk3-dark, which is not the official theme name, as we can see in their repo: https://gitlab.gnome.org/Archive/gnome-themes-extra/-/blob/master/themes/Adwaita-dark/index.theme.in?ref_type=heads#L6

So my suggestion is to change the following method to include the official Adwaita name (maybe checking for both official and adw-gtk3):

cosmic-settings-daemon/src/theme.rs

Line 531 in 2f17f33

"adw-gtk3-dark",

[mmstick]

It's intended to use adw-gtk3 on COSMIC. It's not the Adwaita theme.

[fulalas]

It's intended to use adw-gtk3 on COSMIC. It's not the Adwaita theme.

Sorry, this is just wrong since adw-gtk3 is not official so many users will have GTK3 light/dark theme broken in COSMIC.

[mmstick]

As above, it is used by COSMIC for GTK3 theme support. GTK3 applications will inherit the chosen COSMIC color scheme.

[fulalas]

I'm not following you.

I decided to install adw-gtk3 theme (which includes adw-gtk3-dark) and here's the result:

1.mp4

I'm not showing in the video, but if I run gsettings set org.gnome.desktop.interface gtk-theme 'adw-gtk3-dark' the application changes to dark mode.

So it seems we have 2 problems here:

1. cosmic-settings-daemon, although running, it's not calling gsetttings... when I change the appearance from light to dark and vice-versa in cosmic-settings
2. cosmic-settings-daemon is assuming adw-gtk3 theme is installed, which is not standard (i.e. it should be Adwaita)

[mmstick]

As mentioned previously on the other issue, cosmic-settings-daemon will only use adw-gtk3 if global GTK theme support is enabled in the experimental settings context drawer on the appearance settings page. This matches the COSMIC color scheme to all GTK3, GTK4, and libadwaita applications.

[fulalas]

OK, enabling this make it work:

But very often it takes a long time (30 seconds or so) for the theme to be updated in GTK3 applications after I switch the appearance from dark to light and vice-versa, and even restarting the GTK3 application. The COSMIC apps change instantly though.

Also, cosmic-session is constantly crashing in VirtualBox 7.1.2 (the reason why recording a video is almost impossible):

simplescreenrecorder-2024-10-01_14.55.00.mp4

In my real machine changing the display scale usually freezes the machine with no way to get back unless powering off/on

I know it's still in alpha, but my suggestion is to give priority to crashes. Also, documenting the requirements, like this non-official obscure adw-gtk3.

Thanks!

[mmstick]

If you are using a virtual machine, you must enable OpenGL hardware acceleration. Then you won't have crashes anymore.

[fulalas]

You mean this Enable 3D Acceleration, like this?

COSMIC doesn't even boot with this unchecked.

The same system running GNOME gives me this and OpenGL and GNOME animations just work:

[mmstick]

Try a different graphics controller. Some will require that you install virtualbox guest additions in the VM.