Text input #143
Merged
Text input #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with merging if the only concern is handling multi-color text. That's something we can add later. Is there anywhere where multi-color text input is used? |
Not really that I can think of, aside from a text input with selected text, where the highlighted text should take the on_accent color instead of the regular text color |
mmstick
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost ready. Right now it supports all of the designed text inputs, except for the animated expandable text input. But I've currently only enabled it with the wayland feature. I am a bit unsure of how to handle text with multiple colors, for example, selected text taking on_accent, while regular text would be on_component , so for now it just does one color. I'm going to look more into how I can do that, but I'm not sure if that should block this.