bump generator to 0.8.3 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pop-os#116. Since currently config::configuration_files is only used with 'static, we change all of its lifetime to 'static. Ref: Xudong-Huang/generator-rs#49
hack3ric
added a commit
to hack3ric/archriscv-packages
that referenced
this pull request
Nov 19, 2024
Bump generator crate which supports riscv64 in 0.8.x. Upstreamed to pop-os/system76-scheduler#120.
jacobgkau
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Regression testing passed:
- Focus-based assignments are working with the default config (both .debs and Flatpaks).
- Focus-based assignments work with custom values in
/etc. -
nice -n #works with the default config. - A custom profile with no niceness defined still has foreground/background applied.
- Only applied at launch. (Not a regression.)
- A custom profile with a niceness defined inline (under
process-scheduler/) works. - A custom profile with a niceness defined separately (in
config.kdl) works. - Config reloading works with
system76-scheduler daemon reload,systemctl reload com.system76.Scheduler.service, andsystemctl restart com.system76.Scheduler.service. - PipeWire integration works; when an app starts playing audio, it's assigned the niceness of the
pipewiregroup and retains it until it's closed. It gets regular foreground/background niceness again when it's relaunched (or sooner if the audio stream stops.) - After disabling the foreground/background profiles, other profiles still work.
The failing Focal build is not a problem because we have a separate master_focal branch that this PR will not affect.
mmstick
approved these changes
Nov 20, 2024
felixonmars
pushed a commit
to felixonmars/archriscv-packages
that referenced
this pull request
Nov 26, 2024
Bump generator crate which supports riscv64 in 0.8.x. Upstreamed to pop-os/system76-scheduler#120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116. Since currently config::configuration_files is only used with 'static, we change all of its lifetime to 'static.
Ref: Xudong-Huang/generator-rs#49