Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.all() improvements #41

Open
voidus opened this issue Feb 4, 2022 · 0 comments
Open

.all() improvements #41

voidus opened this issue Feb 4, 2022 · 0 comments

Comments

@voidus
Copy link
Contributor

voidus commented Feb 4, 2022

Semantically, .all() should not be a method of the CountryInfo object, since that one represents the information for a specific country.

Instead, it should probably be a global function. While we're at it, I'd also say it should return a list of CountryInfo objects. If a user wants to access a specific one, they can create a CountryInfo object, so fast access isn't a big issue, and it would hide the json structure from library users.

Implementation-wise, this would be easier after #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant