Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handy helper in node-postgres: allowExitOnIdle #918

Open
matthiasfeist opened this issue Jul 23, 2024 · 0 comments
Open

Handy helper in node-postgres: allowExitOnIdle #918

matthiasfeist opened this issue Jul 23, 2024 · 0 comments

Comments

@matthiasfeist
Copy link

Hi.

I recently migrated from node-postgres to postgres.js and ran into the issue that my script would never finish as the connection was still open and therefore block the node event loop.
node-postgres has a config option for this: allowExitOnIdle which they describe like this:

Default behavior is the pool will keep clients open & connected to the backend
until idleTimeoutMillis expire for each client and node will maintain a ref
to the socket on the client, keeping the event loop alive until all clients are closed
after being idle or the pool is manually shutdown with pool.end().

Setting allowExitOnIdle: true in the config will allow the node event loop to exit
as soon as all clients in the pool are idle, even if their socket is still open
to the postgres server. This can be handy in scripts & tests
where you don't want to wait for your clients to go idle before your process exits.

I believe that would be a great feature to have in postgres.js as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant