From 7b978b79c0020355caf712c7b7a260d9eafc697f Mon Sep 17 00:00:00 2001 From: Mark Thompson <129641948+NotherNgineer@users.noreply.github.com> Date: Thu, 20 Jul 2023 15:20:27 -0500 Subject: [PATCH 1/2] Temporary hang workaround --- firmware/application/apps/capture_app.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/firmware/application/apps/capture_app.cpp b/firmware/application/apps/capture_app.cpp index 6d0e4c660..4fc819920 100644 --- a/firmware/application/apps/capture_app.cpp +++ b/firmware/application/apps/capture_app.cpp @@ -48,6 +48,14 @@ CaptureAppView::CaptureAppView(NavigationView& nav) &waterfall, }); + /* THE ONE LINE BELOW IS A TEMPORARY KLUDGE WORKAROUND FOR A MYSTERY M4 BASEBAND HANG ISSUE WHEN THE CAPTURE + APP IS THE FIRST APP STARTED AFTER POWER-UP, OR THE CAPTURE APP IS RUN AFTER RUNNING REPLAY WITH A HIGH + SAMPLE RATE. IT SHOULD NOT BE NECESSARY SINCE sampling_rate IS ALREADY INITIALIZED BY RADIOSTATE BUT + APPARENTLY IS ADDING JUST THE RIGHT AMOUNT OF DELAY. ISSUE DOES NOT AFFECT ALL PORTAPACK UNITS. + INVESTIGATION IS ONGOING, SEE ISSUE #1283. */ + receiver_model.set_sampling_rate(3072000); + /* END MYSTERY HANG WORKAROUND. */ + field_frequency_step.set_by_value(receiver_model.frequency_step()); field_frequency_step.on_change = [this](size_t, OptionsField::value_t v) { receiver_model.set_frequency_step(v); From 7f35f14b4ddbba00322cc4a8143e3273d195687e Mon Sep 17 00:00:00 2001 From: Mark Thompson <129641948+NotherNgineer@users.noreply.github.com> Date: Thu, 20 Jul 2023 15:28:41 -0500 Subject: [PATCH 2/2] Clang found a trailing space in a comment :-) --- firmware/application/apps/capture_app.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/firmware/application/apps/capture_app.cpp b/firmware/application/apps/capture_app.cpp index 4fc819920..e331d26f0 100644 --- a/firmware/application/apps/capture_app.cpp +++ b/firmware/application/apps/capture_app.cpp @@ -49,7 +49,7 @@ CaptureAppView::CaptureAppView(NavigationView& nav) }); /* THE ONE LINE BELOW IS A TEMPORARY KLUDGE WORKAROUND FOR A MYSTERY M4 BASEBAND HANG ISSUE WHEN THE CAPTURE - APP IS THE FIRST APP STARTED AFTER POWER-UP, OR THE CAPTURE APP IS RUN AFTER RUNNING REPLAY WITH A HIGH + APP IS THE FIRST APP STARTED AFTER POWER-UP, OR THE CAPTURE APP IS RUN AFTER RUNNING REPLAY WITH A HIGH SAMPLE RATE. IT SHOULD NOT BE NECESSARY SINCE sampling_rate IS ALREADY INITIALIZED BY RADIOSTATE BUT APPARENTLY IS ADDING JUST THE RIGHT AMOUNT OF DELAY. ISSUE DOES NOT AFFECT ALL PORTAPACK UNITS. INVESTIGATION IS ONGOING, SEE ISSUE #1283. */