Skip to content

Commit

Permalink
Enable Kubernetes aggregation by default
Browse files Browse the repository at this point in the history
* Change `enable_aggregation` default from false to true
* These days, Kubernetes control plane components emit annoying
messages related to assumptions baked into the Kubernetes API
Aggregation Layer if you don't enable it. Further the conformance
tests force you to remember to enable it if you care about passing
those
* This change is motivated by eliminating annoyances, rather than
any enthusiasm for Kubernetes' aggregation features
* https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/apiserver-aggregation/
  • Loading branch information
dghubble committed Oct 6, 2021
1 parent c6fa09b commit fadb5bb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ variable "enable_reporting" {

variable "enable_aggregation" {
type = bool
description = "Enable the Kubernetes Aggregation Layer (defaults to false, recommended)"
default = false
description = "Enable the Kubernetes Aggregation Layer (defaults to true)"
default = true
}

variable "daemonset_tolerations" {
Expand Down

0 comments on commit fadb5bb

Please sign in to comment.